Skip to content

Make rows in contract table actual links to allow opening in new tab with cmd click #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Make rows in contract table actual links to allow opening in new tab with cmd click #5142

merged 1 commit into from
Oct 23, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 23, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the DeployedContractsPageHeader and related components for better usability and design. It introduces new features and refines existing functionalities in the contract table, particularly regarding link overlays and styling.

Detailed summary

  • Updated DeployedContractsPageHeader to use a new Button import.
  • Modified AsyncContractNameCell to accept a new linkOverlay prop.
  • Adjusted Link component in AsyncContractNameCell to conditionally apply styles based on linkOverlay.
  • Passed linkOverlay prop to AsyncContractNameCell in the ContractTable.
  • Enhanced styling for Button components within the ContractTable.
  • Removed unnecessary useChainSlug import from deployed-contracts.tsx.
  • Refined ContractTableRow to streamline event handling and styling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 5:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 23, 2024 5:19pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 23, 2024 5:19pm
wallet-ui ⬜️ Skipped (Inspect) Oct 23, 2024 5:19pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 15:50 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7a1099b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 23, 2024
@MananTank MananTank marked this pull request as ready for review October 23, 2024 15:50
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.43%. Comparing base (4e5fdcf) to head (7a1099b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5142   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files        1066     1066           
  Lines       55150    55150           
  Branches     3974     3974           
=======================================
  Hits        25055    25055           
  Misses      29403    29403           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4e5fdcf
packages 40.45% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 2.7 s (-25.3% 🔽) 3.6 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 8.3 s (+10.51% 🔺) 10.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 195 ms (-30.72% 🔽) 292 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 256 ms (+202.96% 🔺) 266 ms
thirdweb/react (minimal + tree-shaking) 17.33 KB (0%) 347 ms (0%) 408 ms (+7.87% 🔺) 754 ms

jnsdls
jnsdls approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesyes

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 23, 2024 •
edited
Loading

Merge activity

@MananTank
Make rows in contract table actual links to allow opening in new tab …
7a1099b 
…with cmd click (#5142)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `DeployedContractsPageHeader` and related components by improving the link handling for contract names and refining the UI elements in the contract table.

### Detailed summary
- Updated `DeployedContractsPageHeader` to use a new `Button` import.
- Added `linkOverlay` prop to `AsyncContractNameCell`.
- Enhanced link styling in `AsyncContractNameCell` with conditional classes.
- Passed `linkOverlay` prop when rendering `AsyncContractNameCell` in the contract table.
- Simplified event handling in `ContractTableRow`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-23-make_rows_in_contract_table_actual_links_to_allow_opening_in_new_tab_with_cmd_click branch from 7cbf028 to 7a1099b Compare October 23, 2024 17:09
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 17:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 17:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 17:09 Inactive
@graphite-app graphite-app bot merged commit 7a1099b into main Oct 23, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-23-make_rows_in_contract_table_actual_links_to_allow_opening_in_new_tab_with_cmd_click branch October 23, 2024 17:20
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 23, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 23, 2024 17:20 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 23, 2024 17:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls